[U-Boot] [PATCH] kirkwood: Fix uninitialised DRAM struct
Gray Remlin
g_remlin at rocketmail.com
Tue Oct 19 15:18:11 CEST 2010
Breaking out of the loop leaves the rest of the struct uninitialised
Signed-off-by: Gray Remlin <g_remlin at rocketmail.com>
---
arch/arm/cpu/arm926ejs/kirkwood/dram.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/kirkwood/dram.c
b/arch/arm/cpu/arm926ejs/kirkwood/dram.c
index 7439c87..50bed63 100644
--- a/arch/arm/cpu/arm926ejs/kirkwood/dram.c
+++ b/arch/arm/cpu/arm926ejs/kirkwood/dram.c
@@ -75,11 +75,8 @@ int dram_init(void)
* If the gap is found, ram_size will be reported for
* consecutive memory only
*/
- if (gd->bd->bi_dram[i].start != gd->ram_size)
- break;
-
- gd->ram_size += gd->bd->bi_dram[i].size;
-
+ if (gd->bd->bi_dram[i].start == gd->ram_size)
+ gd->ram_size += gd->bd->bi_dram[i].size;
}
return 0;
}
--
More information about the U-Boot
mailing list