[U-Boot] [PATCH] USB: sync Queue Element Transfer Descriptor against EHCI spec

Wolfgang Denk wd at denx.de
Wed Oct 20 00:26:35 CEST 2010


In message <1287497595-22758-1-git-send-email-wd at denx.de> I wrote:
> Appendix B "EHCI 64-Bit Data Structures" of the "Enhanced Host
> Controller Interface Specification for Universal Serial Bus" (Rev.
> 1.0, March 12, 2002) defines additional fields which were missing in
> U-Boot's struct qTD; as these are also present in recent versions of
> struct ehci_qtd in the Linux kernel, we add them here, too.
> 
> This fixes some nasty memory corruption problems.
> 
> Reported-by: Dan Lykowski <lykowdk at gmail.com>
> See http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/76942
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Remy Bohmer <linux at bohmer.net>
> Cc: Dan Lykowski <lykowdk at gmail.com>
> Cc: Stefano Babic <sbabic at denx.de>
> Tested-by: Stefano Babic <sbabic at denx.de>
> ---
> 
> Dear Remy,
> 
> this patch goes back to an old posting by Dan Lykowski.
> 
> Unfortunately Dan never submitted a patch, so this went unfixed until
> now, when the bug bit Stefano...
> 
> Best regards,
> 
> Wolfgang
> 
> 
>  drivers/usb/host/ehci-hcd.c |    1 +
>  drivers/usb/host/ehci.h     |   14 +++++++++-----
>  2 files changed, 10 insertions(+), 5 deletions(-)

Applied directly.

Remy, I hope this is OK with you.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I must follow the people.  Am I not their leader? - Benjamin Disraeli


More information about the U-Boot mailing list