[U-Boot] [PATCH] Kirkwood: bugfix: broken early console messages

[Prafulla Wadaskar]

> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de] 
> Sent: Wednesday, October 20, 2010 4:42 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH] Kirkwood: bugfix: broken early 
> console messages
> 
> Hello Prafulla,
> 
> Prafulla Wadaskar wrote:
> > It has been observed that, the complete u-boot banner
> > does not appear on the console when the system is booted
> > from NAND/NOR/SPI flash.
> > 
> > This patch fixes this issue on all Marvell boards by adding
> > board_early_init_f() support
> > 
> > Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> > ---
> >  board/Marvell/guruplug/guruplug.c               |    6 +++++-
> >  board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c |    6 +++++-
> >  board/Marvell/openrd_base/openrd_base.c         |    6 +++++-
> >  board/Marvell/rd6281a/rd6281a.c                 |    6 +++++-
> >  board/Marvell/sheevaplug/sheevaplug.c           |    6 +++++-
> >  include/configs/mv-common.h                     |    1 +
> >  6 files changed, 26 insertions(+), 5 deletions(-)
> > 
> > diff --git a/board/Marvell/guruplug/guruplug.c 
> b/board/Marvell/guruplug/guruplug.c
> > index 4df4e9b..1f0e67a 100644
> > --- a/board/Marvell/guruplug/guruplug.c
> > +++ b/board/Marvell/guruplug/guruplug.c
> > @@ -30,7 +30,7 @@
> >  
> >  DECLARE_GLOBAL_DATA_PTR;
> >  
> > -int board_init(void)
> > +int board_early_init_f(void)
> >  {
> 
> Maybe, you can make a mv-common.c which contains this
> (and maybe other mv common?) functions?

I thought of it,
but specifically for this function, which is doing GPIOs and MPP configuration only, and generally it is very board specific.

But having mv-common.c is not a bad idea..
Let's check it out in next step :-)

Regards..
Prafulla . .