[U-Boot] [RFC] [PATCH] kirkwood: get rid of config.mk files

Wolfgang Denk wd at denx.de
Thu Oct 21 10:21:48 CEST 2010


Dear Prafulla,

In message <F766E4F80769BD478052FB6533FA745D19A6A465EB at SC-VEXCH4.marvell.com> you wrote:
> 
> > -		$(obj)tools/mkimage -n $(KWD_CONFIG) -T kwbimage \
> > +		$(obj)tools/mkimage \
> > +		-n $(SRCTREE)/board/$(CONFIG_BOARDDIR)/kwbimage.cfg \

Note: I have to admit that I don't really understand what the command
is supposed to do (which is why I asked you for help with the
testing).

The "-n" option to mkimage means "set image name to 'name'", so the
file name given as argument here would only change the name string
inside the image, but not affect the image content at all.

I guess this is not how it's supposed to work?


> This will not address other forecasted use cases like-
> 1. if the new board is added to boards/ (i.e. no BOARDDIR)
>
> 2. it will force each board to have it's own kwbimage.cfg even though two
> boards need same configuration, i.e. code duplication.
> 
> In my opinion, we can keep this default setup with CONFIG_SYS_KWD_CONFIG
> support in addition.

I'm not sure what exactly you mean here. Do you man to replace

	$(SRCTREE)/board/$(CONFIG_BOARDDIR)/kwbimage.cfg

by something like

	$(SRCTREE)/board/$(CONFIG_SYS_KWD_CONFIG)

?  I would agree with that, too.

But I definitely want to avoid to have any such board specific
configuration information in the config.mk files.  Ideally, I want to
get completely rid of all board specific config.mk files.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating is a word I use for the unexpected.
	-- Spock, "The Squire of Gothos", stardate 2124.5


More information about the U-Boot mailing list