[U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block

Wolfgang Denk wd at denx.de
Thu Oct 21 22:22:57 CEST 2010


Dear Gray Remlin,

In message <4CC09695.6070702 at rocketmail.com> you wrote:
> Labels added to endifs to aid readability of the net/bootp.c file.
> A block of code was marked for conditional compilation but the condition
> could never arise, the ifdef\endif code block has been deleted.
...

> -#if defined(CONFIG_CMD_DHCP)
> -       *e++ = 53;              /* DHCP Message Type */
> -       *e++ = 1;
> -       *e++ = DHCP_DISCOVER;
> -
> -       *e++ = 57;              /* Maximum DHCP Message Size */
> -       *e++ = 2;
> -       *e++ = (576 - 312 + OPT_SIZE) >> 16;
> -       *e++ = (576 - 312 + OPT_SIZE) & 0xff;
> -#endif

What makes you think CONFIG_CMD_DHCP was never used? There are 270+
boards that use this!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Technology is dominated by those who manage what they do  not  under-
stand.


More information about the U-Boot mailing list