[U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block

[Wolfgang Denk]

Dear Reinhard Meyer,

In message <4CC0A479.4040900 at emk-elektronik.de> you wrote:
>
> >> -#if defined(CONFIG_CMD_DHCP)
> >> -       *e++ = 53;              /* DHCP Message Type */
> >> -       *e++ = 1;
> >> -       *e++ = DHCP_DISCOVER;
> >> -
> >> -       *e++ = 57;              /* Maximum DHCP Message Size */
> >> -       *e++ = 2;
> >> -       *e++ = (576 - 312 + OPT_SIZE)>>  16;
> >> -       *e++ = (576 - 312 + OPT_SIZE)&  0xff;
> >> -#endif
> >
> > What makes you think CONFIG_CMD_DHCP was never used? There are 270+
> > boards that use this!
> 
> Its in the ELSE part like this:

Ouch.

> #if defined(CONFIG_CMD_DHCP)
> ...
> #else
> ...
> #if defined(CONFIG_CMD_DHCP)
> ...
> #endif
> ...
> #endif
> 
> Perhaps it should be investigated how it happened to become such dead code?

Indeed. This cannot be right / intentional.

Just deleting it seems wrong in any case.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
People are very flexible and learn to adjust to strange  surroundings
--  they can become accustomed to read Lisp and Fortran programs, for
example.   - Leon Sterling and Ehud Shapiro, Art of Prolog, MIT Press