[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Sughosh Ganu]

hi Wolfgang,
On Thu Oct 21, 2010 at 10:30:09PM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
> 
> In message <1287690158-6055-1-git-send-email-urwithsughosh at gmail.com> you wrote:
> > Move and rename common header files from under board/davinci to the
> > standard include file path. 
> > 
> > Signed-off-by: Sughosh Ganu <urwithsughosh at gmail.com>
> > ---
> > This patch is needed for adding board support for the hawkboard which
> > uses nand_spl based boot mechanism.
> 
> Why would that be the case?

  The board file is symlinked under the nand_spl/board directory and
  we cannot do relative path based file inclusion.


> I don't like to move davinci specific headers into the top level
> include/ directory. That's inherently wrong.
> 
> If these headers are indeed common to all davinci boards, they should
> probably be moved to arch/arm/cpu/arm926ejs/davinci/

  Ok. In that case, i guess i can keep them in the same place. Would
  rename them as davinci_misc.h and da8xx_common.h, and add the
  include path in my board's config.mk. Is this fine.

> 
> >  board/davinci/common/misc.c               |    2 +-
> >  board/davinci/common/misc.h               |   54 -----------------------------
> >  board/davinci/da8xxevm/common.c           |    2 +-
> >  board/davinci/da8xxevm/common.h           |   30 ----------------
> >  board/davinci/da8xxevm/da830evm.c         |    4 +-
> >  board/davinci/da8xxevm/da850evm.c         |    4 +-
> >  board/davinci/dm355evm/dm355evm.c         |    2 +-
> >  board/davinci/dm355leopard/dm355leopard.c |    2 +-
> >  board/davinci/dm365evm/dm365evm.c         |    2 +-
> >  board/davinci/dvevm/dvevm.c               |    2 +-
> >  board/davinci/schmoogie/schmoogie.c       |    2 +-
> >  board/davinci/sffsdr/sffsdr.c             |    2 +-
> >  board/davinci/sonata/sonata.c             |    2 +-
> >  include/da8xx_common.h                    |   30 ++++++++++++++++
> >  include/davinci_misc.h                    |   54 +++++++++++++++++++++++++++++
> >  15 files changed, 97 insertions(+), 97 deletions(-)
> >  delete mode 100644 board/davinci/common/misc.h
> >  delete mode 100644 board/davinci/da8xxevm/common.h
> >  create mode 100644 include/da8xx_common.h
> >  create mode 100644 include/davinci_misc.h
> 
> Please use the "-M" option with "git format-patch" to make it detect
> such renames.

  Ok. Will do. Thanks.

-sughosh