[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

Sughosh Ganu urwithsughosh at gmail.com
Fri Oct 22 10:46:41 CEST 2010


hi Wolfgang,

On Fri Oct 22, 2010 at 10:26:08AM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
> 
> In message <20101022080434.GC8597 at Hardy> you wrote:
> > 
> > > Which points out where the actual problem comes from: relative path
> > > based file inclusion is a Bad Thing and should be avoided.
> > 
> >   So then can we remove the relative path based inclusion used by all
> >   files under board/davinci. We would need to add corresponding path
> >   entries to the board's config.mk.
> 
> Please don't. Assume that all config.mk files are candidates for
> removal.
> 
> Rather put commonly used header files in places where they can be
> found easily.

  Which is what i was trying in the first place :). Any place other
  than the include directory would need us to specifiy the path to the
  files. Where can we put such information then, if not
  config.mk. Please let me know.


> > > I don't understand what you man by "keep them in the same place".
> > > Where?
> > 
> >   I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and
> >   keep them in their current location under board/davinci.
> 
> That does not solve the problem, then, it seems.

  Yes, in case we do not move it to the standard include path, i don't
  think we are adding any value by moving it under the arch
  directory. Please let me know how to proceed on this.

-sughosh


More information about the U-Boot mailing list