[U-Boot] [PATCH 01/10 v2] net: rtl8169: Add initialized eth_device structure

Nobuhiro Iwamatsu iwamatsu at nigauri.org
Mon Oct 25 21:02:09 CEST 2010


Hi, Ben and Wolfgang.

Could you take in these patches?

Best regards,
  Nobuhiro

2010/10/19 Nobuhiro Iwamatsu <iwamatsu at nigauri.org>:
> rtl8169 does not have write_hwaddr function.
> However, eth stuff executes write_hwaddr function
> because eth_device structure has not been initialized.
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
> CC: Ben Warren <biggerbadderben at gmail.com>
> ---
>  drivers/net/rtl8169.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c
> index e45d1a5..d6bc514 100644
> --- a/drivers/net/rtl8169.c
> +++ b/drivers/net/rtl8169.c
> @@ -894,7 +894,12 @@ int rtl8169_initialize(bd_t *bis)
>                debug ("rtl8169: REALTEK RTL8169 @0x%x\n", iobase);
>
>                dev = (struct eth_device *)malloc(sizeof *dev);
> -
> +               if (!dev) {
> +                       printf("Can not allocate memory of rtl8169\n");
> +                       break;
> +               }
> +
> +               memset(dev, 0, sizeof(*dev));
>                sprintf (dev->name, "RTL8169#%d", card_number);
>
>                dev->priv = (void *) devno;
> --
> 1.7.1
>
>



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6


More information about the U-Boot mailing list