[U-Boot] [PATCH 1/2] mx51evk: support new relocation scheme

[Stefano Babic]

On 10/26/2010 10:25 AM, Heiko Schocher wrote:
> Hello Stefano,
> 
> Stefano Babic wrote:
>> On 10/26/2010 10:05 AM, Shawn Guo wrote:
>>> Hi Stefano,
>>>
>>> On Tue, Oct 26, 2010 at 3:59 PM, Stefano Babic <sbabic at denx.de> wrote:
>>>> On 10/25/2010 05:14 PM, Shawn Guo wrote:
>>>>
>>>>> +#define CONFIG_SYS_SDRAM_BASE        PHYS_SDRAM_1
>>>>> +#define CONFIG_SYS_INIT_SP_ADDR      (IRAM_BASE_ADDR + 0x1000)
>>>> What is the meaning of the offset at 0x1000 ? Is there something at
>>>> IRAM_BASE_ADDR ?
>>>>
>>> I thought CONFIG_SYS_INIT_SP_ADDR is assigned to stack pointer (sp)
>>> which decrease the address.  Is it not the case?
>>>
>>
>> Yes, my doubt is due to the fact that we do not set the SP at the end of
>> the IRAM and we set it to an arbitrary address in between.
> 
> We should set the CONFIG_SYS_INIT_SP_ADDR @ (IRAM_BASE_ADDR + IRAM_BASE_SIZE
> - CONFIG_SYS_GBL_DATA_SIZE)

Agree, this is what I set for the vision2 board. We should be consistent
and do the same for the mx51evk.

> 
> Don;t know if IRAM_BASE_SIZE exists ...

we must define it. I set it in the board configuration file, but it is
wrong. The value should be moved into register definition file for the
SoC (imx-regs.h)

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================