[U-Boot] [PATCH V2] imx25: Fix reset
Jason Liu
liu.h.jason at gmail.com
Tue Oct 26 18:44:23 CEST 2010
Hi,
2010/10/26 Matthias Weißer <weisserm at arcor.de>:
> Am 26.10.2010 11:27, schrieb Reinhard Meyer:
>> Dear Matthias Weisser,
>>> This patch fixes the reset command on imx25
>>>
>>> Signed-off-by: Matthias Weisser<weisserm at arcor.de>
>>> + writew(0x00000000,®s->wcr);
>>> + writew(0x00005555,®s->wsr);
>>> + writew(0x0000AAAA,®s->wsr);
>>
>> It might be "nicer" to use 16 Bit constants (with 4 hex digits)
>> here..?
>
> Sure. Would be nicer. I wait a bit for further comments and will create
> a V3 then.
Add please append to the commit log about why you make such change?
It will be clear to read and understand your change for this patch.
>
> Matthias
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
More information about the U-Boot
mailing list