[U-Boot] [PATCH v3] ARM: Use consistent assembler syntax
Wolfgang Denk
wd at denx.de
Tue Oct 26 20:53:24 CEST 2010
Dear Gray Remlin,
In message <4CC44E47.2050107 at rocketmail.com> you wrote:
>
> Signed-off-by: Gray Remlin <g_remlin at rocketmail.com>
> ---
> Patch V3 Subject line correction change to patch v2 from
> "arm926ejs: Fix two occurrences of illegal syntax assembler instructions"
> originally used in patch v1, as it now impacts more than one CPU type.
>
>
> arch/arm/cpu/arm1136/start.S | 4 ++--
> arch/arm/cpu/arm926ejs/start.S | 4 ++--
> arch/arm/cpu/armv7/start.S | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
> index 29ed065..0425b54 100644
> --- a/arch/arm/cpu/arm1136/start.S
> +++ b/arch/arm/cpu/arm1136/start.S
> @@ -238,7 +238,7 @@ copy_loop:
> add r3, r3, r0 /* r3 <- rel dyn end in FLASH */
> fixloop:
> ldr r0, [r2] /* r0 <- location to fix up, IN FLASH! */
> - add r0, r9 /* r0 <- location to fix up in RAM */
> + add r0, r0, r9 /* r0 <- location to fix up in RAM */
> ldr r1, [r2, #4]
> and r8, r1, #0xff
> cmp r8, #23 /* relative fixup? */
> @@ -252,7 +252,7 @@ fixabs:
> mov r1, r1, LSR #4 /* r1 <- symbol index in .dynsym */
> add r1, r10, r1 /* r1 <- address of symbol in
> table */
Your patch is line wrapped and white space corrupted. I applied it
manually, but please fix your mailer, or, even better, use "git
send-email" to submit patches.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Peace was the way.
-- Kirk, "The City on the Edge of Forever", stardate unknown
More information about the U-Boot
mailing list