[U-Boot] [PATCH 3/3 v2] Replace CONFIG_SYS_GBL_DATA_SIZE by auto-generated value

Alessandro Rubini rubini-list at gnudd.com
Tue Oct 26 22:57:56 CEST 2010


>> This has already been applied, sooner than usual.  Isn't it cleaner to
>> force alignment on the structure itself? This way different architectures
>> may use different values, if the need arises.
> 
> It would be better, but how to implement that?

Instead of:

     DEFINE(GENERATED_GBL_DATA_SIZE,
             (sizeof(struct global_data)+15) & ~15);

I'd use:

     DEFINE(GENERATED_GBL_DATA_SIZE,
             (sizeof(struct global_data)),

leaving the alignment requirement in the structure itself
(include/asm/global_data.h for each architecture).

/alessandro


More information about the U-Boot mailing list