[U-Boot] [PATCH] cmd_net: drop spurious comma in U_BOOT_CMD

Mike Frysinger vapier at gentoo.org
Wed Oct 27 02:45:35 CEST 2010


On Tuesday, October 26, 2010 17:45:10 Wolfgang Denk wrote:
> In message <20101026191510.5AC28152451 at gemini.denx.de> I wrote:
> > Mike Frysinger wrote:
> > > Building for boards that have CONFIG_CMD_CDP enabled fail with:
> > > cmd_net.c:301: error: expected expression before ',' token
> > 
> > Applied, thanks.
> 
> I wish I had tested this before applying - and even more I wish you
> had run MAKEALL as requested when sumbitting patches.

actually, as i had stated in one of my other patches, i *was* running MAKEALL 
but the vast majority of boards were failing (probably because of your patches 
you noted some time later).  for the few boards that didnt fail in that way, 
they were failing *because of this code*.

i wrote the patch *because* MAKEALL was reporting failures due to this code.  
but perhaps the failure i was seeing was just fallout of the bad patches you 
had pushed already.  i guess i dont really care because none of my boards were 
or are failing due to this, and i'll stop trying to fix other people's board 
failures.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101026/ed655b40/attachment.pgp 


More information about the U-Boot mailing list