[U-Boot] [RFC] [PATCH 0/4] Add support for Freescale's 85xx and P1/P2xxx eSPI controller

[Can Aydin]

On 13/10/2010 9:25 PM, Xie Shaohui-B21989 wrote:
> Hi Can,
>
> Are there any differences between your patches and
> http://lists.denx.de/pipermail/u-boot/2009-March/049093.html ?
>
>
> Best Regards,
> Shaohui Xie
>

Hello Shaohui,

Firstly,  I apologize for responding so late, we've been having some 
issues with our mail server.

In terms of differences, the big trivial one is that any modifications 
to common code such as spi_flash have been removed from the latest 
iteration of the patch. It is now just an eSPI driver with support added 
for cmd_spi in  P1_P2_RDB.h.

You'll note that the more significant change is that the spi_xfer 
function works quite differently now; the older version called an 80us 
delay between the tx and rx buffer accesses and always assumed that the 
rx buffer had valid data, this caused problems when transferring large 
amounts data at higher clock rates as tx/rx over-/under-flows would 
cause data corruption.

Hence, additional macros have also been defined for the various register 
fields that need to be checked for tx/rx buffer states during the 
read/write cycle.

Smaller, more cosmetic changes have also been made to reduce magic 
numbers and such.

I've been trying to send in the v3 submission of the patch for a couple 
of days now but have not, as yet, succeeded in getting it through. Third 
time lucky I hope.

Regards,

Can