[U-Boot] [PATCH v2] mx51evk: support new relocation scheme

[Stefano Babic]

On 10/27/2010 01:54 PM, Shawn Guo wrote:
> On Wed, Oct 27, 2010 at 7:46 PM, Wolfgang Denk <wd at denx.de> wrote:
>> Dear Shawn Guo,
>>
>> In message <1288174358-14896-1-git-send-email-shawn.gsc at gmail.com> you wrote:
>>> This patch is to fix build breakage and support new relocatoin
>>> scheme for mx51evk.
>>>
>>> - Correct IRAM base address and add size definition
>>>
>>>   The IRAM starts from 0x1FFE0000 on final revsion i.mx51 than
>>>   0x1FFE8000 which is for older revision.
>>>
>>> - Include imx-regs.h in mx51evk.h
>>>
>>>   Definitions like CSD0_BASE_ADDR and IRAM_BASE_ADDR can be
>>>   referred to.
>>>
>>> - Define CONFIG_SYS_INIT_RAM_ADDR and CONFIG_SYS_INIT_RAM_SIZE
>>>
>>>   This is something suggested by Wolfgang, and for automatic
>>>   calculation of macros like CONFIG_SYS_GBL_DATA_SIZE (done) and
>>>   CONFIG_SYS_INIT_SP_ADDR (later).
>>
>> Um... this is NOT what we discussed.
>>
> Are you saying that automatic calculation of CONFIG_SYS_INIT_SP_ADDR
> will not happen?
> 
>>
>> No.  This is not what I want to se.
>>
>> Memory allocation in the inital ram has the global data at the top.
>>
>> Please use something like
>>
>> #define CONFIG_SYS_INIT_SP_OFFSET  (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
>> #define CONFIG_SYS_INIT_SP_ADDR    (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
>>
> If the automatic calculation of CONFIG_SYS_INIT_SP_ADDR will not
> happen, I can send another patch to fix it, since it's been applied by
> Stefano already.

Sorry for that. I was too fast and I have not read the patch with
attention. I revert the patch after I see Wolfgang's comment. You can
send V3 version of this patch and you can forget the "applied" message.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================