[U-Boot] [PATCH 1/2] imx: Get fec mac address from fuse

[John Rigby]

On Wed, Oct 27, 2010 at 2:06 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear John,
>
> In message <AANLkTikMZvAsVW1WtwG7od9QYeaPHHWdBC+3OX5Akv3L at mail.gmail.com> you wrote:
>>
>> The patch fixes the particular case where you have no ethaddr in fuse,
>> nor persistent env.  The case is a board where the only persistent
>> storage is an SD card and you set load a boot script from file in a
>
> Well, if ther eis no MAC address in the fuse, and there is no
> "ethaddr" setting in the current environment, then nothing should
> happen until you try to run the first network command, at wich point
> the command should fail because the MAC address is unset.
>
>> FAT partition that has a setenv ethaddr in it.  The other case is if a
>> user sets the ethaddr at the command line it will not take effect
>> until reboot in the case of persistent env or never in the case of no
>> persistent env.
>
> This is broken behaviour; in this case, the network driver needs to be
> fixed. The driver initialization takes place when you start a network
> command, and it should pick up the MAC address setting then, mo matter
> if this was permanently stored or just entered on the command line.
Thanks for saying this because this is exactly what my original patch
fixes.  So the fix should stay.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "A child is a person who can't understand why someone would give away
> a perfectly good kitten."                               - Doug Larson
>