[U-Boot] [PATCH] env_sf: remove warning introduced with last patch

Mike Frysinger vapier at gentoo.org
Thu Oct 28 19:47:53 CEST 2010


On Thu, Oct 28, 2010 at 6:39 AM, Stefano Babic wrote:
> Signed-off-by: Stefano Babic <sbabic at denx.de>
> ---
>  common/env_sf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/env_sf.c b/common/env_sf.c
> index a597b24..e5e0166 100644
> --- a/common/env_sf.c
> +++ b/common/env_sf.c
> @@ -272,7 +272,7 @@ int saveenv(void)
>        u32 saved_size, saved_offset;
>        char *saved_buffer = NULL;
>        u32 sector = 1;
> -       int ret;
> +       int ret = 1;
>        env_t   env_new;
>        char    *res;
>        ssize_t len;

if you're going to start at 1, shouldnt you then drop the redundant
assignment to 1 ?
        if (!saved_buffer) {
            ret = 1;
            goto done;
        }
-mike


More information about the U-Boot mailing list