[U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted

[Wolfgang Denk]

Dear Stefan Roese,

In message <1288267776-1148-1-git-send-email-sr at denx.de> you wrote:
> Only allow (re-)assignment to an UBI partition/device when UBIFS is
> currently not mounted. Otherwise the following UBIFS commands will
> crash.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  common/cmd_ubi.c   |   13 +++++++++++++
>  common/cmd_ubifs.c |    5 +++++
>  2 files changed, 18 insertions(+), 0 deletions(-)

I'm a bit biased here - from standard Unix command usage it seems
natural that you have to manually umount first, but then we have very
smple device handling in U-Boot, with always only one device in
access.  Would it not make sense to auto-unmount in case the user
switches the device?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_