[U-Boot] [PATCH 2/4] cfi_flash: Add weak default for cfi_flash_bank_addr()

[Sergei Shtylyov]

Hello.

Stefan Roese wrote:

> cfi_flash_bank_addr(int bank_nr) returns the base addresses of the
> requested bank. Introducing this weak default enables boards to override
> this functions with a board specific version when required.

> This feature will be used in the lwmon5 board update, supporting runtime
> detection of 2 board revisions with different flash layouts.

> Signed-off-by: Stefan Roese <sr at denx.de>
[...]
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index b4a09dc..f10e09e 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
[...]
> @@ -2021,14 +2028,12 @@ unsigned long flash_init (void)
>  	getenv_f("unlock", s, sizeof(s));
>  #endif
>  
> -#define BANK_BASE(i)	(((phys_addr_t [CFI_MAX_FLASH_BANKS])CONFIG_SYS_FLASH_BANKS_LIST)[i])
> -
>  	/* Init: no FLASHes known */
>  	for (i = 0; i < CONFIG_SYS_MAX_FLASH_BANKS; ++i) {
>  		flash_info[i].flash_id = FLASH_UNKNOWN;
>  
> -		if (!flash_detect_legacy (BANK_BASE(i), i))
> -			flash_get_size (BANK_BASE(i), i);
> +		if (!flash_detect_legacy (cfi_flash_bank_addr(i), i))
> +			flash_get_size (cfi_flash_bank_addr(i), i);

    Could remove the sopaces before parens to improve the coding style, while 
at it...

WBR, Sergei