[U-Boot] [PATCH] zlib: Add further watchdog reset calls

Stefan Roese sr at denx.de
Fri Sep 3 09:10:08 CEST 2010


Hi Detlev,

On Thursday 02 September 2010 18:40:38 Detlev Zundel wrote:
> >          case TYPE:
> > +	    if (strm->outcb != Z_NULL)
> > +		    (*strm->outcb)(Z_NULL, 0); /* call WATCHDOG_RESET */
> > 
> >              if (flush == Z_BLOCK) goto inf_leave;
> >          
> >          case TYPEDO:
> >              if (state->last) {
> 
> Can you please tell me (and include in the comment) why this calls a
> watchdog reset and why you did not use a "regular plain WATCHDOG_RESET"?

I did it this way, because that's the way these watchdog reset calls have been 
implemented in the U-Boot zlib version till now. Frankly I'm not sure why it 
was done this way instead of using "regular plain WATCHDOG_RESET" calls. 
Perhaps Wolfgang remembers the reasoning behind it.

I could change this function pointer approach to "regular plain 
WATCHDOG_RESET" call though if preferred. Just let me know and I'll try to 
come up with a new patch version.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list