[U-Boot] [PATCH v2 1/2] APM82xxx: Add CPU and other peripheral support

[Stefan Roese]

Hi Wolfgang,

On Thursday 02 September 2010 21:01:37 Wolfgang Denk wrote:
> Hm.., the whole CPU ID code in "arch/powerpc/cpu/ppc4xx/cpu.c" has
> become a mess.
> 
> Stefan:
> 
> is there any deeper logic for the repeated #ifdef's there, when we
> finally do a switch on the PVR anyway?
> 
> Instead of painstakingly concatenating  "AMCC PowerPC 4" with "05"
> and later "GP Rev. B" we could shrink this into a plain
> 
> 	case PVR_405GP_RB:
> 		puts("AMCC PowerPC 405GP Rev. B");
> 		break;
> 
> Or am I missing something?

IIRC, then the main reason for this is the code size reduction. Using your 
version would increase the code size quite a bit. But I concur, it would be 
much better readable. So just let me know, and I'll try to come up with a 
patch cleaning this up a bit.

> Let's get rid of all these nested #ifdef's...

As described in some comments, the problem is that some SoC's have the same 
PVR (for example 440EP rev C and 440GR rev B have same PVR). I have no idea 
how this identification could be solved without such ifdef's.

But you are right. Some of the ifdef's can be removed. Again, this would also 
result in a bigger image size though.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de