[U-Boot] [PATCH] NET: add ENC28J60 driver using SPI framework

[Mike Frysinger]

On Friday, September 03, 2010 16:31:47 Reinhard Meyer wrote:
> int enc_initialize(int bus, int cs, int speed)

should take the same parameters (including type) as spi_setup_slave

> 	eth_register(&(enc->netdev));

no need for the () before the &

> not sure, however, if calling spi_setup_slave() is ok at this point.

i believe the func should only doing validation on the arguments.  it shouldnt 
need to talk to any actual hardware.  maybe this needs codifying in the API 
documentation.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100903/3bb55261/attachment.pgp