[U-Boot] [PATCH] mvsata_ide: adjust port init sequence

[Sergei Shtylyov]

Hello.

Albert ARIBAUD wrote:

>> On 05.09.2010 23:33, Albert ARIBAUD wrote:

>>>>> + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */
>>>>> control = readl(&port->scontrol);
>>>>> control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT;
>>>>> + /* Toggle control DET back to 0 (normal operation) */

>>>> But you haven't set it to 1 yet. Maybe the comment is misplaced?

>>> Look at the comment above, which said DET was set to 1, and at
>>> MVSATA_PORT_INIT, which combines IPM=3 and DET=1.

>> But you didn't write that value yet before your comment saying that
>> you're resetting DET back to 0.

> Yes, I did:

> #define MVSATA_PORT_INIT \
>     (MVSATA_SCONTROL_DET_INIT|MVSATA_SCONTROL_IPM_NO_LP_ALLOWED)

> MVSATA_PORT_INIT has both IPM = 3 (no low power allowed) and DET = 1 
> (initialize).

    Sigh. Your "resetting DET" comment is before the first writel().

> Amicalement,

WBR, Sergei