[U-Boot] [PATCH] IDE: Don't assume there are always two devices per bus

Wolfgang Denk wd at denx.de
Mon Sep 6 21:35:46 CEST 2010


Dear Albert ARIBAUD,

In message <4C8521A8.6050107 at free.fr> you wrote:
> 
> I don't see much benefit in allocating dynamically rather than 
> statically unless you are really tight on RAM, which seems to not fit 
> with a board which has many busses and disks.
> 
> Plus, IDE may not know about hotplugging, but SATA does, which means I 
> can do an ide_init(), plug or unplug disks, and do an ide_init() again 
> with a different number of devices. Dynamic allocation requires resizing 
> the allocated arrays; static is just less trouble.
> 
> Anyway, static vs dynamic can be done in a second step after adding N 
> busses (and thereby fixing the issue of ghost devices that prompted 
> Rogan's patch proposal).

OK, I agree.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In theory, there is no difference between  theory  and  practice.  In
practice, however, there is.


More information about the U-Boot mailing list