[U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence

Albert ARIBAUD albert.aribaud at free.fr
Tue Sep 7 23:14:28 CEST 2010


Le 07/09/2010 21:00, Wolfgang Denk a écrit :
> Dear Albert ARIBAUD,
>
> In message<4C867741.6060906 at free.fr>  you wrote:
>>
>> I'm a bit lost at the logic of this last sentence. If errors are not
>> always represented as negative return values, and especially so in
>> U-boot, then what is the rationale for supporting a request for
>> specifically negative error return values, rather than positive, here?
>
> Even though ther eis lots of code that could need improvement, we
> should not take such bad examples, but rather try to apply standard
> techniques instead.
>
>> Not that I mind much -- as I said, ide_init() does not mind, and that's
>> my reference -- and I'll happily put negative error codes in V3, but I
>> like to understand why people want things.
>
> It's just a pretty common thing to do, and instead of doing the same
> thing in many different ways it makes some sense to use a standard
> way.

Understood.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list