[U-Boot] [PATCH 6/8] PXA: Voipac270 improvements

Marek Vasut marek.vasut.n900 at gmail.com
Tue Sep 7 23:30:16 CEST 2010


N900 again, sorry.
----- Původní zpráva -----
> Dear Marek Vasut,
> 
> In message <1282296691-15910-6-git-send-email-marek.vasut at gmail.com> you
> wrote:
> > 128MB NOR module support.
> > Define __io to get harddrive working.
> > Fix saving of environment into OneNAND.
> > Boot from harddrive when possible.
> > Add missing MAINTAINERS entry.
> > 
> > Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> > ---
> > Changes same as in PalmTC
> > 
> > MAINTAINERS                                     |       1 +
> > MAKEALL                                             |       3 +-
> > Makefile                                           |       7 ++-
> > board/vpac270/Makefile               |       7 +--
> > board/vpac270/lowlevel_init.S |       1 -
> > board/vpac270/vpac270.c             |     41 ++++++----------
> > include/configs/vpac270.h         |   106
> > +++++++++++++++++++++++----------------- 7 files changed, 87
> > insertions(+), 79 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5d20dca..c35a277 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -800,6 +800,7 @@ Marek Vasut <marek.vasut at gmail.com>
> > 
> >     palmld        xscale
> >     palmtc        xscale
> > +    vpac270        xscale
> > 
> > Hugo Villeneuve <hugo.villeneuve at lyrtech.com>
> > 
> > diff --git a/Makefile b/Makefile
> > index 4f1cb1b..3f2b304 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2180,13 +2180,18 @@ trizepsiv_config    :    unconfig
> >     fi;
> >     @$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv
> > 
> > -vpac270_nor_config \
> > +vpac270_nor_256M_config \
> > +vpac270_nor_128M_config \
> > vpac270_onenand_config    : unconfig
> 
> Um... we don't accept such changes to the Makefile any more. Such
> configuration should be moved to the boards.cfg file instead.

I'm aware of this. Though I have to admit I don't know how to do it through boards.cfg. I will take a look when I get home (in about 1 hour). Or if you'd be so kind to point me in some direction?

Thanks
> 
> ...
> > --- a/board/vpac270/Makefile
> > +++ b/board/vpac270/Makefile
> > @@ -1,10 +1,7 @@
> > -
> > #
> > -# (C) Copyright 2000
> > -# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > +# Voipac PXA270 Support
> > #
> > -# See file CREDITS for list of people who contributed to this
> > -# project.
> > +# Copyright (C) 2010 Marek Vasut <marek.vasut at gmail.com>
> > #
> > # This program is free software; you can redistribute it and/or
> > # modify it under the terms of the GNU General Public License as
> ...
> > diff --git a/board/vpac270/vpac270.c b/board/vpac270/vpac270.c
> > index 18e47e2..2d01e22 100644
> > --- a/board/vpac270/vpac270.c
> > +++ b/board/vpac270/vpac270.c
> > @@ -1,16 +1,7 @@
> > /*
> > - * (C) Copyright 2004
> > - * Robert Whaley, Applied Data Systems, Inc. rwhaley at applieddata.net
> > + * Voipac PXA270 Support
> > *
> > - * (C) Copyright 2002
> > - * Kyle Harris, Nexus Technologies, Inc. kharris at nexus-tech.net
> > - *
> > - * (C) Copyright 2002
> > - * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > - * Marius Groeger <mgroeger at sysgo.de>
> > - *
> > - * See file CREDITS for list of people who contributed to this
> > - * project.
> > + * Copyright (C) 2010 Marek Vasut <marek.vasut at gmail.com>
> 
> What makes you think it was legitimate to delete these old Copyright
> notices?
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,         MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since
> Its Mass, and Thus Its Weight, Is Dependent on Its Velocity   Relative
> to the User.



More information about the U-Boot mailing list