[U-Boot] [PATCH v2] display_buffer: fix misaligned buffer

Reinhard Meyer u-boot at emk-elektronik.de
Wed Sep 8 05:43:22 CEST 2010


Dear Wolfgang Denk,
>> +	/* linebuf as a union causes proper alignment */
>> +	union linebuf {
>> +		uint32_t ui[MAX_LINE_LENGTH_BYTES/4 + 1];
>> +		uint16_t us[MAX_LINE_LENGTH_BYTES/2 + 1];
>> +		uint8_t  uc[MAX_LINE_LENGTH_BYTES/1 + 1];
>
> Please replace the magic numbers 4, 2 and 1 by respective sizeof().


AND


 > Please let's use the attribute version.

Which shall it be now???

Best Regards, Reinhard



More information about the U-Boot mailing list