[U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

[Mike Frysinger]

On Wednesday, September 08, 2010 11:06:54 John Rigby wrote:

please do not top post

> The case I am personally dealing with is one where there is no
> persistent storage
> for ethaddr.  Booting from and SD card and a script is run that sets
> the ethaddr.
> 
> Currently eth_init updates dev->enetaddr for each device but does not call
> dev-write_hwaddr.  This seems like a bug not a policy change.

and if you read the doumentation, you'll see that you're mistaken.  whatever 
device you're dealing with (today) is missing a call to its own write_hwaaddr 
function inside of its own init function.

if you want to fix your immediate issue, then fix that driver as implied by 
the policy.  if you want to improve the policy, then you need to update all 
the drivers and the common code.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100908/f1e94a46/attachment.pgp