[U-Boot] [PATCH 2/4 v2] cfi_flash: Add weak default for cfi_flash_bank_addr()

[Stefan Roese]

Hi Wolfgang,

On Thursday 09 September 2010 12:42:13 Wolfgang Denk wrote:
> > cfi_flash_bank_addr(int bank_nr) returns the base addresses of the
> > requested bank. Introducing this weak default enables boards to override
> > this functions with a board specific version when required.
> 
> ..
> 
> > +	return ((phys_addr_t [])CONFIG_SYS_FLASH_BANKS_LIST)[i];
> 
> ..
> 
> > -#define BANK_BASE(i)	(((phys_addr_t
> > [CFI_MAX_FLASH_BANKS])CONFIG_SYS_FLASH_BANKS_LIST)[i])
> 
> Was the change from "[CFI_MAX_FLASH_BANKS]" to "[]" intentional?

Yes. Do you see a problem with this change?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de