[U-Boot] [PATCH] USB-CDC: Fix coding style issues

Remy Bohmer linux at bohmer.net
Sat Sep 11 09:36:59 CEST 2010


Hi,

2010/9/10  <vkuzmichev at mvista.com>:
> From: Vitaly Kuzmichev <vkuzmichev at mvista.com>
>
> Fixed most of checkpatch warnings and errors in USB gadget stack.
>
> Signed-off-by: Vitaly Kuzmichev <vkuzmichev at mvista.com>
> ---
>  drivers/usb/gadget/config.c       |    2 +-
>  drivers/usb/gadget/epautoconf.c   |   73 ++++----
>  drivers/usb/gadget/ether.c        |  385 ++++++++++++++++++-------------------
>  drivers/usb/gadget/gadget_chips.h |   51 +++---
>  drivers/usb/gadget/usbstring.c    |   42 ++--
>  include/linux/usb/ch9.h           |    4 +-
>  include/linux/usb/gadget.h        |   91 +++++-----
>  7 files changed, 325 insertions(+), 323 deletions(-)
>
> index 344fc78..cad2eeb 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -74,8 +74,9 @@ struct usb_ep;
>  * Bulk endpoints can use any size buffers, and can also be used for interrupt
>  * transfers. interrupt-only endpoints can be much less functional.
>  */
> -       // NOTE this is analagous to 'struct urb' on the host side,
> -       // except that it's thinner and promotes more pre-allocation.
> +       /* NOTE this is analagous to 'struct urb' on the host side,
> +        * except that it's thinner and promotes more pre-allocation.
> +        */

Multi-line comments should be like:
/*
 * comment line 1
 * comment line 2
 */

NOT:
/* comment line 1
 * comment line 2
 */

Apart from that this patch looks good. Please fix globally.

Kind regards,

Remy


More information about the U-Boot mailing list