[U-Boot] [PATCH 2/3] mmc: add boundary check for mmc operation

[Lei Wen]

Fix it in new version of patch set.

Thanks,
Lei

On Thu, Sep 9, 2010 at 10:51 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Lei Wen,
>
> In message <AANLkTi=m3P2w33-a7-ChpVPwU=XA0WTTL2gHV1dTJOWY at mail.gmail.com> you wrote:
>> >>
>> >> +       if (start > mmc->block_dev.lba || (start + blkcnt) mmc->block_dev.lba) {
>> >> +                   printf("\noperation excceed mmc boudary..\n");
>> >
>> > No initial newline, please.
>>
>> You mean add additional line or just reduce a line here?...
>
> I mean change
>
>        printf("\noperation ...");
> into
>        printf("operation ...");
>
>> > Hm... Maybe you could change the message so it is more informatiove,
>> > i. e. tell the user which boundary was exceeded, and what caused this
>> > condition - is this a user error or a problem in the code?
>>
>> Give error message for each judgment of the two?
>
> Not really needed, but you might print the legal range and the current
> value in the error message.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Time is a drug. Too much of it kills you.
>                                      - Terry Pratchett, _Small Gods_
>