[U-Boot] [PATCH] mpc5xxx_fec: add call to reset_phy() after PHY initialization

Wolfgang Denk wd at denx.de
Mon Sep 13 11:33:25 CEST 2010


Dear Ben,

In message <1282208946-18823-1-git-send-email-yanok at emcraft.com> Ilya Yanok wrote:
> Some boards need their board-specific PHY quirks to be called
> to PHY to work normally. As mpc5xxx_fec driver uses on demand
> PHY initialization and can even reinit PHY during normal operation
> we can't count on reset_phy() call from arch/<arch>/lib/board.c
> (it is most likely called _before_ we init the PHY from the
> driver) so we need to add call to reset_phy() directly in the
> driver.
> 
> Cc: Ben Warren <biggerbadderben at gmail.com>
> Signed-off-by: Ilya Yanok <yanok at emcraft.com>
> ---
>  drivers/net/mpc5xxx_fec.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)

Do you have any comments?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A direct quote from the Boss: "We passed over a lot of good people to
get the ones we hired."


More information about the U-Boot mailing list