[U-Boot] [PATCH] da850evm: basic MII EMAC support
Ben Gardiner
bengardiner at nanometrics.ca
Tue Sep 14 15:07:48 CEST 2010
Hi Mike,
Thanks for following-up.
On Tue, Sep 14, 2010 at 9:00 AM, Mike Frysinger <vapier at gentoo.org> wrote:
>
> it depends on the URLs. i dont think referring to the mainline git tree is
> useful at all considering that's what they're using if they have this patch in
Yes, I see your point: the mainline tree's URL is superfluous.
> their tree. as for the omap1 reference, i'm not sure mentioning at all is
> useful in the commit. presumably the tree in question will drop its code and
> move to the mainline stuff one yours is merged. imo, that would make it a
> "note" which goes below the "---".
Ok -- I hadn't fully considered the ramifications of the fact that the
commit message would be around long after the state of the omap-l1
tree had changed. I agree that this URL would be a note below the
'---', if included at all.
> if the URL is generally useful, then some people use a dedicated tag in the
> "s-o-b" section such as "URL: xxx". this isnt exactly standardized.
Neat. I'll keep that one in mind too, but not for external commits --
you have convinced me that it is not useful to include these in he
commit message.
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometrics.ca
More information about the U-Boot
mailing list