[U-Boot] [PATCH] p1022ds: use weak CFI flash accessors when DIU is enabled

[Timur Tabi]

Wolfgang Denk wrote:

> I think the description is wrong - don't you switch from DIU to LBC
> for flash access?

Ugh, yes.  I was getting bug-eyed working on this code.

>> +/* Variables used by the DIU/LBC switching code.  It's safe to makes these
>> + * global, because the DIU requires DDR, so we'll only run this code after
>> + * relocation.
>> + */
> 
> Incorrect multiline comment format.
> 
>> +/**
>> + * set_mux_to_lbc - disable the DIU so that we can read/write to elbc
> 
> Incorrect multiline comment format. Please check and fix globally.

Can you be more specific?  Is it the "**"?

>> +#define CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS
>> +/*
>> + * With CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS, flash I/O is really slow, so
>> + * disable empty flash sector detection, which is I/O-intensive.
>> + */
>> +#undef CONFIG_SYS_FLASH_EMPTY_INFO
> 
> "#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS" / "#endif" arount the
> #undef ?

Why?  CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS is only defined if CONFIG_VIDEO is
defined.  It's just one block of macros.


-- 
Timur Tabi
Linux kernel developer at Freescale