[U-Boot] [u-boot-release] [PATCH] [v3] p1022ds: use weak CFI flash accessorswhen DIU is enabled

[Tabi Timur-B04825]

Jaggi Manish-B10520 wrote:
> Most of the read/write functions do this way
> 0:+       int sw = set_mux_to_lbc();
> 1:+
> 2:+       ret = __raw_readl(addr);
> 3:+       if (sw)
> 4:+               set_mux_to_diu();
>
> compiler might reorder 2 before 3 and 0, read / write wont have any
> issue , right ?

Really?  I don't see why the compiler would do that.  That would be a bug, IMHO.

Can you explain why you think it will make such a reordering?  My 
understanding is that the compiler reorders things that don't have any side 
effects.  Only function calls marked as "const" have no side effects, and 
none of these functions are const functions.

-- 
Timur Tabi
Linux kernel developer