[U-Boot] [PATCH] Config: Add "board options" column to boards.cfg

Wolfgang Denk wd at denx.de
Tue Sep 21 08:21:24 CEST 2010


Dear Marek Vasut,

please fix the mail addresses. My address is wd at denx.de

In message <1285025204-8463-1-git-send-email-marek.vasut at gmail.com> you wrote:
> There are some boards where it's not currently possible to detect all board
> information at runtime, therefore I introduced a new column called "options" to
> boards.cfg .
> 
> This column can contain multiple options, separated by comma [,] . This column
> is case sensitive. In case there's a simple options like 256M_U_BOOT, it's plain
> expanded to "#define CONFIG_256M_U_BOOT" in config.h . In case there's an
> assignment, like "ram=8192", it's expanded to "#define CONFIG_RAM 8192" in
> config.h . There can also be multiple such options, then each is expanded to
> separate "#define CONFIG_xyz" statement.

I don't understand what you mean by "is case sensitive" when in the
end you seem to convert everything to upper case?

I would not make any statement about case sensistivity and copy the
settings unchanged. It is up to the user to provide valid (upper case)
macro names, and it leaves the option to deviate and use locer case
identifiers in case this should ever be needed for some special
purpose.  Also, it makes the code simpler.

And, as Mike pointed out, please reuse the "-y" option.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is easier to write an incorrect program than understand a  correct
one.


More information about the U-Boot mailing list