[U-Boot] [PATCH] fsl_diu_fb: further refactoring of FLS DIU code

Timur Tabi timur at freescale.com
Thu Sep 23 18:32:17 CEST 2010


Anatolij Gustschin wrote:
> This is the first patch version for testing on HW I do not
> have (mpc8610hpcd, p1022ds). Tested on pdm360ng board.
> 
> The patch will be modified to fix board config files as
> needed in the final version. We probably should also move
> fsl_diu_fb.c file to 'drivers/video'.

This works, except the default should be CONFIG_VIDEO is undefined.  It's
unlikely the customer will have a monitor connected to the DVI port.

So ...

> diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h
> index 58d3d99..9f3f843 100644
> --- a/include/configs/MPC8610HPCD.h
> +++ b/include/configs/MPC8610HPCD.h
> @@ -22,7 +22,9 @@
>  #define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
>  
>  /* video */
> -#undef CONFIG_VIDEO
> +#ifdef CONFIG_FSL_DIU_FB
> +#define CONFIG_VIDEO
> +#endif

leave this undefined, and ...

> diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h
> index 8e0117f..523494d 100644
> --- a/include/configs/P1022DS.h
> +++ b/include/configs/P1022DS.h
> @@ -178,7 +178,7 @@
>  #define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
>  
>  /* Video */
> -#undef CONFIG_FSL_DIU_FB
> +#define CONFIG_FSL_DIU_FB

don't make this change.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the U-Boot mailing list