[U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

[Rupjyoti Sarmah]

Hello Wolfgang,


> So moved the reconfiguration to the USB init  function

Does the Linux kernel perform the same initiaalization of the GPIO
pins?  If not, then your change will most likely cause the USB is not
working in Linux unless you used USB in U-Boot.

RUP >> Yes, it does.

> --- a/board/amcc/canyonlands/canyonlands.c
> +

You drop the "if (pvr_460ex()) {" part here. Is this intentional?
RUP>> Yes

Also, when adding this code to usb_board_init(), would it not be
logical to undo this initialization in usb_board_stop()?

RUP >> Ok, I will include your suggestion and resubmit


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In theory, there is no difference between  theory  and  practice.  In
practice, however, there is.