[U-Boot] [PATCH] board/armltd/integrator/split_by_variant.sh: fix 'echo -n'
Mike Frysinger
vapier at gentoo.org
Fri Sep 24 19:04:52 CEST 2010
On Friday, September 24, 2010 12:27:52 Andreas Bießmann wrote:
> - echo -n "#define CONFIG_CM720T" >> ${config_file}
> - echo " 1 /* CPU core is ARM720T */ " >> ${config_file}
> + cat >> ${config_file} << _EOF
> +#define CONFIG_CM720T 1 /* CPU core is ARM720T */
> +_EOF
changing multiline echos to a cat makes sense, but using cat for a single line
is overkill. a simple `echo "..."` is better.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100924/76193dd9/attachment.pgp
More information about the U-Boot
mailing list