[U-Boot] [PATCH 08/14] PXA: Voipac270 improvements

Wolfgang Denk wd at denx.de
Mon Sep 27 21:41:07 CEST 2010


Dear Marek Vasut,

In message <1285226769-9619-8-git-send-email-marek.vasut at gmail.com> you wrote:
> 128MB NOR module support.
> Define __io to get harddrive working.
> Fix saving of environment into OneNAND.
> Boot from harddrive when possible.
> Add missing MAINTAINERS entry.
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  MAINTAINERS                   |    1 +
>  MAKEALL                       |    3 +-
>  Makefile                      |    7 ++-
>  board/vpac270/Makefile        |    7 +--
>  board/vpac270/lowlevel_init.S |    1 -
>  board/vpac270/vpac270.c       |   44 ++++++-----------
>  include/configs/vpac270.h     |  106 +++++++++++++++++++++++-----------------
>  7 files changed, 88 insertions(+), 81 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c6fe1d3..7ba4b8b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -797,6 +797,7 @@ Marek Vasut <marek.vasut at gmail.com>
>  
>  	palmld		xscale
>  	palmtc		xscale
> +	vpac270		xscale
>  
>  Hugo Villeneuve <hugo.villeneuve at lyrtech.com>
>  
> diff --git a/MAKEALL b/MAKEALL
> index 1b506d6..9dd3636 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -546,7 +546,8 @@ LIST_at91="			\
>  LIST_pxa="$(boards_by_cpu pxa)
>  	polaris		\
>  	trizepsiv	\
> -	vpac270_nor	\
> +	vpac270_nor_128M\
> +	vpac270_nor_256M\
>  	vpac270_onenand	\

We do not accept such additions to MAKEALL any more.  This shouldbe
handled through boards.cfg; see previous discussion.

>  
> diff --git a/Makefile b/Makefile
> index 84947d0..e62d0cc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2187,13 +2187,18 @@ trizepsiv_config	:	unconfig
>  	fi;
>  	@$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv
>  
> -vpac270_nor_config \
> +vpac270_nor_256M_config \
> +vpac270_nor_128M_config \
>  vpac270_onenand_config	: unconfig

Ditto.


> diff --git a/board/vpac270/vpac270.c b/board/vpac270/vpac270.c
> index f792298..1557d1b 100644
> --- a/board/vpac270/vpac270.c
> +++ b/board/vpac270/vpac270.c
> @@ -1,16 +1,7 @@
>  /*
> - * (C) Copyright 2004
> - * Robert Whaley, Applied Data Systems, Inc. rwhaley at applieddata.net
> + * Voipac PXA270 Support
>   *
> - * (C) Copyright 2002
> - * Kyle Harris, Nexus Technologies, Inc. kharris at nexus-tech.net
> - *
> - * (C) Copyright 2002
> - * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> - * Marius Groeger <mgroeger at sysgo.de>
> - *
> - * See file CREDITS for list of people who contributed to this
> - * project.
> + * Copyright (C) 2010 Marek Vasut <marek.vasut at gmail.com>

I guess this file was originally copied from some other source? Why is
it OK to remove the original Copyrights?



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An armed society is a polite society.


More information about the U-Boot mailing list