[U-Boot] [PATCH v6 1/2] APM821xx: Add CPU support

Wolfgang Denk wd at denx.de
Tue Sep 28 20:57:01 CEST 2010


Dear tmarri at apm.com,

In message <1285698750-4943-1-git-send-email-tmarri at apm.com> you wrote:
> From: Tirumala Marri <tmarri at apm.com>
> 
> APM821XX is a new line of SoCs which are derivatives of
> PPC44X family of processors. This patch adds support of CPU, cache,
> tlb, 32k ocm, bootstraps, PLB and AHB bus.
...
> -#if (defined(CONFIG_405EP) || defined (CONFIG_405EX)) && !defined(CONFIG_SYS_4xx_GPIO_TABLE)
> +#if !defined(CONFIG_APM821XX) && (defined(CONFIG_405EP) ||\
> +		defined (CONFIG_405EX)) && !defined(CONFIG_SYS_4xx_GPIO_TABLE)

Please reorder to avoid breaking the expression in parens, and to
keep the list sorted (in the other places you also sort the 'A' after
the '4', as one would expect), for example:

#if (defined(CONFIG_405EP) || defined (CONFIG_405EX)) && \\
    !defined(CONFIG_APM821XX) && !defined(CONFIG_SYS_4xx_GPIO_TABLE)



Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Who is the oldest inhabitant of this village?"
"We haven't got one; we had one, but he died three weeks ago."


More information about the U-Boot mailing list