[U-Boot] [PATCH V2 1/7] Expand POST memory test to support arch-depended implementation.

York Sun yorksun at freescale.com
Tue Sep 28 21:24:29 CEST 2010


On Tue, 2010-09-28 at 20:50 +0200, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1285696512.30239.14.camel at oslab-l1> you wrote:
> > On Tue, 2010-09-28 at 19:31 +0200, Wolfgang Denk wrote:
> > 
> > > > -int memory_post_test (int flags)
> > > > +__attribute__((weak))
> > > > +int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset)
> > > 
> > > phys_offset is unused here. Drop it?
> > > 
> > 
> > The phys_offset is not used by _this_ weak function but it is used by
> > another function implemented in the third patch. Is it OK to leave the
> > unused phys_offset here?
> 
> What does the compiler say?

I don't have any warning or error.

York





More information about the U-Boot mailing list