[U-Boot] [PATCH 12/17] post/i2c: Don't probe address 0

Heiko Schocher hs at denx.de
Thu Sep 30 08:10:09 CEST 2010


Hello Peter,

Peter Tyser wrote:
> According to the I2C specification device address 0 is the "general call
> address", ie a broadcast address.  The I2C specification states that the
> format of a general call uses at least 2 bytes, which U-Boot's probing
> routine does not adhere to.
> 
> Not probing device address 0 will prevent possible issues with devices
> that accept general calls.  Additionally, this change shouldn't reduce
> POST coverage since each I2C device should still be accessed via its
> own, unique address.
> 
> Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> CC: hs at denx.de
> ---
>  post/drivers/i2c.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

Thanks!

Applies clean on top of master.

Acked-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list