[U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices
Wolfgang Denk
wd at denx.de
Thu Sep 30 09:44:47 CEST 2010
Dear Peter Tyser,
In message <1285828543.20234.5.camel at ptyser-laptop> you wrote:
>
> The existing I2C_ADDR_LIST isn't documented, so I didn't document this
> addition. I'll mention them both in doc/README.POST.
Thanks.
What I don't understand yet: why do we need a balck (ignore) list at
all, when we already have a white list (I2C_ADDR_LIST) ?
Should not one be sufficient?
> > Hmm.. as this is only used in post code, this should be visible
> > in the defines name, what with:
> >
> > I2C_POST_ADDR_IGNORE_LIST
>
> I was following the lead of the existing I2C_ADDR_LIST define. Agreed
> it should be named differently. I'll go with CONFIG_SYS_POST_I2C_ADDRS
> and CONFIG_SYS_POST_I2C_IGNORES unless someone else chimes in.
Argh... I don't like identifiers that need half a line or more...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bus error -- please leave by the rear door.
More information about the U-Boot
mailing list