[U-Boot] [PATCH v3 2/2] hwmon: do not init sensors on startup
Wolfgang Denk
wd at denx.de
Mon Aug 1 12:12:24 CEST 2011
Dear Heiko Schocher,
In message <1307610451-13457-1-git-send-email-hs at denx.de> you wrote:
> The U-Boot Design Principles[1] clearly say:
>
> Initialize devices only when they are needed within U-Boot, i.e. don't
> initialize the Ethernet interface(s) unless U-Boot performs a download
> over Ethernet; don't initialize any IDE or USB devices unless U-Boot
> actually tries to load files from these, etc. (and don't forget to
> shut down these devices after using them - otherwise nasty things may
> happen when you try to boot your OS).
>
> So, do not initialize and read the sensors on startup.
>
> Signed-off-by: Heiko Schocher <hs at denx.de>
> cc: Wolfgang Denk <wd at denx.de>
> cc: Holger Brunck <holger.brunck at keymile.com>
Checkpatch says:
ERROR: do not initialise statics to 0 or NULL
#111: FILE: common/cmd_dtt.c:31:
+static unsigned long sensor_initialized = 0;
Please fix and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A door is what a dog is perpetually on the wrong side of.
- Ogden Nash
More information about the U-Boot
mailing list