[U-Boot] [PATCH 3/3 v2] cfb_console.c: checkpatch cleanup
Wolfgang Denk
wd at denx.de
Mon Aug 1 15:17:21 CEST 2011
Dear Wolfgang Denk,
In message <1312066089-16812-1-git-send-email-wd at denx.de> you wrote:
> Fix the following:
>
> ERROR: do not initialise statics to 0 or NULL
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Wolfgang Denk <wd at denx.de>
...
> - if ((s = getenv("splashpos")) != NULL) {
> + s = getenv("splashpos");
> + if ((s != NULL) {
-------------------^^ Grrrgh...
Applied after fixing this bug.
Best regards,
Viele Grüße,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have the simplest tastes. I am always satisfied with the best.
-- Oscar Wilde
More information about the U-Boot
mailing list