[U-Boot] [PATCH v2] arm/kirkwood: print speeds with cpu info.

[Jason]

On Mon, Aug 01, 2011 at 02:53:00PM +0200, Wolfgang Denk wrote:
> Dear Jason Cooper,
> 
> In message <1312160667-14248-1-git-send-email-u-boot at lakedaemon.net> you wrote:
> > If CONFIG_DISPLAY_CPUINFO is enabled on kirkwood SoCs, this will print the
> > speeds of the various components.
> > 
> > Signed-off-by: Jason Cooper <u-boot at lakedaemon.net>
> > ---
> > Changes since v1:
> > 	- optimized macros to remove one-timers
> > 	- reduced switch/case to if/else since it operates on one bit.
> > 	- remove RFC
> > 
> >  arch/arm/cpu/arm926ejs/kirkwood/cpu.c    |   41 ++++++++++++++++++++++++++++++
> >  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 +
> >  2 files changed, 42 insertions(+), 0 deletions(-)
> ...
> > +	printf("CPU running @ %dMHz L2 running @ %dMHz\n",
> > +		cpu_clk, l2_clk);
> > +	printf("SysClock = %dMHz, TClock = %dMHz\n",
> > +		sys_clk, t_clk / 1000000);
> 
> Please do NOT print such information as part of the regular,
> unconditionally printed boot messages.

Is CONFIG_DISPLAY_CPUINFO always set?  A quick grep / wc -l of
include/configs/*.h shows 64 enabled out of 590 files.

> We want to keep thes einformatiove, but otherwise as short as
> possible.

Agreed.
 
> I recommend to use the "clock" command to print such information  then
> the user is free to decide if he wants to see this, or not.

Interesting.  Let me know if CONFIG_DISPLAY_CPUINFO satisfies your
concerns.  If not, I'll be happy to add this to 'clock'.

thx,

Jason.