[U-Boot] [PATCH 4/4] fsl_ifc: Add the workaround for erratum IFC A-003399(enabled on P1010)

Kumar Gala galak at kernel.crashing.org
Mon Aug 1 17:16:15 CEST 2011


On Aug 1, 2011, at 5:21 AM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <1312180248-28528-4-git-send-email-galak at kernel.crashing.org> you wrote:
>> From: Poonam Aggrwal <poonam.aggrwal at freescale.com>
>> 
>> Issue: Address masking doesn't work properly.
>> When sum of the base address, defined by BA, and memory bank size,
>> defined by AM, exceeds 4GB (0xffff_ffff) then AMASKn[AM] doesn't mask
>> CSPRn[BA] bits.
>> 
>> Impact:
>> This will impact booting when we are reprogramming CSPR0(BA) and
>> AMASK0(AMASK) while executing from NOR Flash.
>> 
>> Workaround:
>> Re-programming of CSPR(BA) and AMASK is done while not executing from NOR
>> Flash. The code which programs the BA and AMASK is executed from L2-SRAM.
>> 
>> Signed-off-by: Poonam Aggrwal <poonam.aggrwal at freescale.com>
>> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> 
> Checkpatch says:
> 
> ERROR: trailing whitespace
> #148: FILE: arch/powerpc/cpu/mpc85xx/cpu_init_early.c:95:
> +^I_mas1 = MAS1_VALID | MAS1_TID(0) | MAS1_TS | MAS1_IPROT | $
> 
> Please cleanup.
> 
> 
> 
> Kumar,  could you __please__ get used to running your patches throuch
> checkpatch __before__ submitting?  Thanks.

I try to, but not all of them are by me ;)

Will be nice when have a version of checkpatch in u-boot source tree.

- k


More information about the U-Boot mailing list