[U-Boot] [PATCH] AT91:mmc:fix multiple read/write error

Andy Fleming afleming at gmail.com
Tue Aug 2 16:05:06 CEST 2011


> I find it highly irregular that this patch has made it into mainline!
>
> 1. We have had a discussion about that I think the approach in this
> patch is wrong. My concerns have not been addressed yet.


I have seen no such discussion. I saw no comments on this patch, so I
applied it. In an idea world, I would read all of the u-boot list
messages, but in reality I filter heavily, and often only look for
messages in the same thread as the patch when deciding whether to
apply (it was also a fairly simple-seeming patch).


>
> 2. This is clearly an ATMEL domain/custodian patch.


It's also clearly an MMC domain/custodian patch, as the changes rest
solely within the MMC directory.


>
> 3. I was not put on CC by Elen.


Elen should have put you on CC, I agree.


>
> 4. Andy snapped it away and applied it without sending an "Applied to"
> message.

I should have sent the message, but it wouldn't have affected things,
much. The gap between application and pull request tends to be fairly
short. Could you point me to the discussion, so I can see your
objections? I'd be happy to revert the patch.


More information about the U-Boot mailing list